spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3755][Core] avoid trying privileged por...
Date Thu, 02 Oct 2014 22:40:01 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2623#discussion_r18372619
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -1437,7 +1437,13 @@ private[spark] object Utils extends Logging {
         val serviceString = if (serviceName.isEmpty) "" else s" '$serviceName'"
         for (offset <- 0 to maxRetries) {
           // Do not increment port if startPort is 0, which is treated as a special port
    -      val tryPort = if (startPort == 0) startPort else (startPort + offset) % 65536
    +      val _tryPort = if (startPort == 0) startPort else (startPort + offset) % 65536
    --- End diff --
    
    Ah never mind, got it. If we ask for 65537 then it wraps around to try 1025.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message