spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nchammas <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3479] [Build] Report failed test catego...
Date Thu, 02 Oct 2014 01:03:47 GMT
Github user nchammas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2606#discussion_r18318239
  
    --- Diff: dev/run-tests-jenkins ---
    @@ -84,42 +98,46 @@ function post_message () {
       fi
     }
     
    +
    +# We diff master...$ghprbActualCommit because that gets us changes introduced in the
PR
    +#+ and not anything else added to master since the PR was branched.
    +
     # check PR merge-ability and check for new public classes
     {
       if [ "$sha1" == "$ghprbActualCommit" ]; then
    -    merge_note=" * This patch **does not** merge cleanly!"
    +    merge_note=" * This patch **does not merge cleanly**."
       else
         merge_note=" * This patch merges cleanly."
    +  fi
    +  
    +  source_files=$(
    --- End diff --
    
    We can do a valid diff regardless of the merge-ability of the patch, so I moved this out
of the if block.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message