Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: yhuai <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-2570-spark@git.apache.org>
In-Reply-To: <git-pr-2570-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-3343] [SQL] Add serde support for
 CTAS
Content-Type: text/plain
Message-Id: <20140930200843.F049EA0C250@tyr.zones.apache.org>
Date: Tue, 30 Sep 2014 20:08:43 +0000 (UTC)

Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2570#discussion_r18243382
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateTableAsSelect.scala ---
    @@ -30,25 +32,38 @@ import org.apache.spark.sql.hive.MetastoreRelation
      * Create table and insert the query result into it.
      * @param database the database name of the new relation
      * @param tableName the table name of the new relation
    - * @param insertIntoRelation function of creating the `InsertIntoHiveTable` 
    - *        by specifying the `MetaStoreRelation`, the data will be inserted into that table.
    - * TODO Add more table creating properties,  e.g. SerDe, StorageHandler, in-memory cache etc.
    + * @param allowExisting allow continue working if it's already exists, otherwise
    + *                      raise exception
    + * @param extra the extra information for this Operator, it should be the
    + *              ASTNode object for extracting the CreateTableDesc.
    + * @param query the query whose result will be insert into the new relation
      */
     @Experimental
     case class CreateTableAsSelect(
       database: String,
       tableName: String,
    -  query: SparkPlan,
    -  insertIntoRelation: MetastoreRelation => InsertIntoHiveTable)
    +  allowExisting: Boolean,
    +  extra: AnyRef,
    +  query: LogicalPlan)
         extends LeafNode with Command {
     
       def output = Seq.empty
     
    +  private[this] def sc = sqlContext.asInstanceOf[HiveContext]
    +
       // A lazy computing of the metastoreRelation
       private[this] lazy val metastoreRelation: MetastoreRelation = {
    -    // Create the table 
    -    val sc = sqlContext.asInstanceOf[HiveContext]
    -    sc.catalog.createTable(database, tableName, query.output, false)
    +    // Get the CreateTableDesc from Hive SemanticAnalyzer
    +    val sa = new SemanticAnalyzer(sc.hiveconf)
    --- End diff --
    
    Do we have to use Hive's SemanticAnalyzer?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org