Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: erikerlandson <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-2455-spark@git.apache.org>
In-Reply-To: <git-pr-2455-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-3250] Implement Gap Sampling
 optimizati...
Content-Type: text/plain
Message-Id: <20140919192955.B3A3BA1DB7B@tyr.zones.apache.org>
Date: Fri, 19 Sep 2014 19:29:55 +0000 (UTC)

Github user erikerlandson commented on the pull request:

    https://github.com/apache/spark/pull/2455#issuecomment-56223584
  
    @mengxr you're right, a data partitioning use case like rddSplit doesn't work with gap sampling, so I restored a "partitioning" RandomSampler subclass that works for those cases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org