Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: viper-kun <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-2391-spark@git.apache.org>
In-Reply-To: <git-pr-2391-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-3562]Periodic cleanup event logs
Content-Type: text/plain
Message-Id: <20140919024205.3DF33A1CB42@tyr.zones.apache.org>
Date: Fri, 19 Sep 2014 02:42:05 +0000 (UTC)

Github user viper-kun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2391#discussion_r17766911
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
    @@ -100,6 +125,12 @@ private[history] class FsHistoryProvider(conf: SparkConf) extends ApplicationHis
         checkForLogs()
         logCheckingThread.setDaemon(true)
         logCheckingThread.start()
    +
    +    if(conf.getBoolean("spark.history.cleaner.enable", false)) {
    +      cleanLogs()
    +      logCleaningThread.setDaemon(true)
    +      logCleaningThread.start()
    +    }
    --- End diff --
    
    yes，you are right. it is no need to clean it on initialization.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org