Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: mengxr <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-2294-spark@git.apache.org>
In-Reply-To: <git-pr-2294-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-3418] Sparse Matrix support (CCS)
 and a...
Content-Type: text/plain
Message-Id: <20140918045332.2D730A1A459@tyr.zones.apache.org>
Date: Thu, 18 Sep 2014 04:53:32 +0000 (UTC)

Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2294#discussion_r17709096
  
    --- Diff: mllib/src/test/scala/org/apache/spark/mllib/linalg/BreezeMatrixConversionSuite.scala ---
    @@ -37,4 +37,26 @@ class BreezeMatrixConversionSuite extends FunSuite {
         assert(mat.numCols === breeze.cols)
         assert(mat.values.eq(breeze.data), "should not copy data")
       }
    +
    +  test("sparse matrix to breeze") {
    +    val values = Array(1.0, 2.0, 4.0, 5.0)
    +    val colPointers = Array(0, 2, 4)
    +    val rowIndices = Array(1, 2, 1, 2)
    +    val mat = Matrices.sparse(3, 2, colPointers, rowIndices, values)
    +    val breeze = mat.toBreeze.asInstanceOf[BSM[Double]]
    +    assert(breeze.rows === mat.numRows)
    +    assert(breeze.cols === mat.numCols)
    +    assert(breeze.data.eq(mat.asInstanceOf[SparseMatrix].values), "should not copy data")
    +  }
    +
    +  test("sparse breeze matrix to sparse matrix") {
    +    val values = Array(1.0, 2.0, 4.0, 5.0)
    +    val colPointers = Array(0, 2, 4)
    --- End diff --
    
    `colPtrs`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org