Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: pwendell <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-1486-spark@git.apache.org>
In-Reply-To: <git-pr-1486-spark@git.apache.org>
Subject: [GitHub] spark pull request: SPARK-1767: Prefer HDFS-cached replicas
 when s...
Content-Type: text/plain
Message-Id: <20140915185119.7A435A14022@tyr.zones.apache.org>
Date: Mon, 15 Sep 2014 18:51:19 +0000 (UTC)

Github user pwendell commented on the pull request:

    https://github.com/apache/spark/pull/1486#issuecomment-55638524
  
    Added a few more comments after thinking about this some more. As it stands the current factoring opens up a bunch of things at `private[spark]` visibility. We always try to use the narrowest visibility possible and I think it would be easy to change this to have only a single `private[spark]` function call with a narrow interface.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org