spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3647] Add more exceptions to Guava relo...
Date Mon, 22 Sep 2014 22:38:20 GMT
GitHub user vanzin opened a pull request:

    https://github.com/apache/spark/pull/2496

    [SPARK-3647] Add more exceptions to Guava relocation.

    Guava's Optional refers to some package private classes / methods, and
    when those are relocated the code stops working, throwing exceptions.
    So add the affected classes to the exception list too, and add a unit
    test.
    
    (Note that this unit test only really makes sense in maven, since we
    don't relocate in the sbt build. Also, JavaAPISuite doesn't seem to
    be run by "mvn test" - I had to manually add command line options to
    enable it.)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vanzin/spark SPARK-3647

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/2496.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2496
    
----
commit 84f58d75005a0133efe5f29be5e0ba1d7ffad288
Author: Marcelo Vanzin <vanzin@cloudera.com>
Date:   2014-09-22T22:08:43Z

    [SPARK-3647] Add more exceptions to Guava relocation.
    
    Guava's Optional refers to some package private classes / methods, and
    when those are relocated the code stops working, throwing exceptions.
    So add the affected classes to the exception list too, and add a unit
    test.
    
    (Note that this unit test only really makes sense in maven, since we
    don't relocate in the sbt build. Also, JavaAPISuite doesn't seem to
    be run by "mvn test" - I had to manually add command line options to
    enable it.)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message