spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3606] [yarn] Correctly configure AmIpFi...
Date Sat, 27 Sep 2014 05:07:12 GMT
Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/2469#issuecomment-57042685
  
    Hey @vanzin I left relatively minor comments. I see in this patch we make an attempt to
make the filter params a little more type safe, which is very welcome. I'm not super fond
of putting a json blob into a config, but I don't really have great suggestions for alternatives
either. One thing we could do is to break the map down into multiple configs that share the
prefix `spark.$filterName.param.*`. Maybe that's a little cleaner, but I don't feel super
strongly about it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message