spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: Spark Core - [SPARK-3620] - Refactor of SparkS...
Date Fri, 26 Sep 2014 00:10:26 GMT
Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/2516#issuecomment-56904113
  
    Hi @tigerquoll, this is slowly improving. I kinda skipped the test code, although I did
notice some issues with it.
    
    Overall, I still caught a few bugs just from visual inspection; these bugs should have
been caught by tests. If you tests didn't catch them, you need to improve them.
    
    Also, I recommend running the "scalastyle" target if you're using sbt to build (maven
should run that automatically for you). There's also the `dev/run-tests` script which might
be a good idea for you to try, if you haven't yet.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message