spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1813. Add a utility to SparkConf that ma...
Date Thu, 25 Sep 2014 19:06:54 GMT
Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/789#issuecomment-56867764
  
    Hey @sryza this looks good. Creating a custom class is cumbersome if the user is just
trying things out, and now it becomes 1 extra line to do it. Will the new API work in Java?
Also, `spark.kryo.registrator` is still documented in the list of configurations. Maybe we
should an entry for `spark.kryo.classesToRegister` on this list as well in addition to showing
how the user can add them dynamically as you have done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message