spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ishiihara <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-CORE [SPARK-3651] Group common CoarseGra...
Date Thu, 25 Sep 2014 11:33:43 GMT
Github user Ishiihara commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2533#discussion_r18026563
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
    @@ -85,16 +79,18 @@ class CoarseGrainedSchedulerBackend(scheduler: TaskSchedulerImpl,
actorSystem: A
         def receiveWithLogging = {
           case RegisterExecutor(executorId, hostPort, cores) =>
             Utils.checkHostPort(hostPort, "Host port expected " + hostPort)
    -        if (executorActor.contains(executorId)) {
    +        if (executorData.contains(executorId)) {
               sender ! RegisterExecutorFailed("Duplicate executor ID: " + executorId)
             } else {
               logInfo("Registered executor: " + sender + " with ID " + executorId)
               sender ! RegisteredExecutor
    -          executorActor(executorId) = sender
    -          executorHost(executorId) = Utils.parseHostPort(hostPort)._1
    -          totalCores(executorId) = cores
    -          freeCores(executorId) = cores
    -          executorAddress(executorId) = sender.path.address
    +          executorData.put(executorId, new ExecutorData(
    --- End diff --
    
    I prefer to construct ExecutorData object with parameters the same order as fields defined
in ExecutorData class. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message