spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3495] Block replication fails continuou...
Date Tue, 23 Sep 2014 17:27:41 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2366#discussion_r17924427
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ---
    @@ -787,31 +789,88 @@ private[spark] class BlockManager(
       }
     
       /**
    +   * Get peer block managers in the system.
    +   */
    +  private def getPeers(forceFetch: Boolean): HashSet[BlockManagerId] = {
    +    val cachedPeersTtl = conf.getInt("spark.storage.cachedPeersTtl", 60 * 1000) // milliseconds
    +    val timeout = System.currentTimeMillis - lastPeerFetchTime > cachedPeersTtl
    +
    +    cachedPeers.synchronized {
    --- End diff --
    
    Ah yes, good point.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message