spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3477] Clean up code in Yarn Client / Cl...
Date Mon, 22 Sep 2014 21:18:00 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2350#discussion_r17878817
  
    --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
    @@ -415,41 +381,153 @@ trait ClientBase extends Logging {
             "1>", ApplicationConstants.LOG_DIR_EXPANSION_VAR + "/stdout",
             "2>", ApplicationConstants.LOG_DIR_EXPANSION_VAR + "/stderr")
     
    -    logInfo("Yarn AM launch context:")
    -    logInfo(s"  user class: ${args.userClass}")
    -    logInfo(s"  env:        $env")
    -    logInfo(s"  command:    ${commands.mkString(" ")}")
    -
         // TODO: it would be nicer to just make sure there are no null commands here
         val printableCommands = commands.map(s => if (s == null) "null" else s).toList
         amContainer.setCommands(printableCommands)
     
    -    setupSecurityToken(amContainer)
    +    logDebug("===============================================================================")
    +    logDebug("Yarn AM launch context:")
    +    logDebug(s"    user class: ${Option(args.userClass).getOrElse("N/A")}")
    +    logDebug("    env:")
    +    launchEnv.foreach { case (k, v) => logDebug(s"        $k -> $v") }
    +    logDebug("    resources:")
    +    localResources.foreach { case (k, v) => logDebug(s"        $k -> $v")}
    +    logDebug("    command:")
    +    logDebug(s"        ${printableCommands.mkString(" ")}")
    +    logDebug("===============================================================================")
     
         // send the acl settings into YARN to control who has access via YARN interfaces
         val securityManager = new SecurityManager(sparkConf)
         amContainer.setApplicationACLs(YarnSparkHadoopUtil.getApplicationAclsForYarn(securityManager))
    +    setupSecurityToken(amContainer)
    +    UserGroupInformation.getCurrentUser().addCredentials(credentials)
     
         amContainer
       }
    +
    +  /**
    +   * Report the state of an application until it has exited, either successfully or
    +   * due to some failure, then return the application state.
    +   *
    --- End diff --
    
    Ok, added.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message