spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sryza <...@git.apache.org>
Subject [GitHub] spark pull request: Modify default YARN memory_overhead-- from an ...
Date Mon, 22 Sep 2014 08:24:52 GMT
Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2485#discussion_r17837060
  
    --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
---
    @@ -117,9 +118,10 @@ private[yarn] abstract class YarnAllocator(
     
         if (missing > 0) {
           numPendingAllocate.addAndGet(missing)
    -      logInfo("Will Allocate %d executor containers, each with %d memory".format(
    +      logInfo("Will Allocate %d executor containers, each with %d+%d MB memory".format(
    --- End diff --
    
    This quantities in this message may be unclear to those not familiar with the overhead.
 Maybe something like "each with %d memory including %d overhead"?
    
    Also, not the fault of this PR, but "Allocate" shouldn't be capitalized.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message