spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3562]Periodic cleanup event logs
Date Sat, 20 Sep 2014 00:31:13 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2391#discussion_r17816167
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
---
    @@ -214,6 +245,27 @@ private[history] class FsHistoryProvider(conf: SparkConf) extends
ApplicationHis
         }
       }
     
    +  /**
    +   *  Deleting apps if setting cleaner.
    +   */
    +  private def cleanLogs() = {
    +    lastLogCleanTimeMs = System.currentTimeMillis()
    +    logDebug("Cleaning logs. Time is now %d.".format(lastLogCleanTimeMs))
    +    try {
    +      val logStatus = fs.listStatus(new Path(resolvedLogDir))
    +      val logDirs = if (logStatus != null) logStatus.filter(_.isDir).toSeq else Seq[FileStatus]()
    +      val maxAge = conf.getLong("spark.history.fs.maxAge", 604800) * 1000
    +      logDirs.foreach{
    +        case dir: FileStatus =>
    +          if(System.currentTimeMillis() - getModificationTime(dir) > maxAge) {
    --- End diff --
    
    nit: `if (`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message