spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2706][SQL] Enable Spark to support Hive...
Date Fri, 19 Sep 2014 19:47:31 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2241#discussion_r17805395
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala
---
    @@ -39,6 +38,8 @@ import org.apache.spark.sql.columnar.InMemoryRelation
     import org.apache.spark.sql.hive.execution.HiveTableScan
     import org.apache.spark.util.Utils
     
    +import org.apache.spark.sql.hive.HiveShim
    +import org.apache.spark.sql.hive.HiveShim._
    --- End diff --
    
    I wouldn't import `HiveShim._` if you are going to qualify all of the accesses below with
`HiveShim` anyway (which I think is a good idea).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message