spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3595] Respect configured OutputCommitte...
Date Fri, 19 Sep 2014 18:19:45 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2450#discussion_r17800209
  
    --- Diff: examples/src/main/scala/org/apache/spark/examples/AwsTest.scala ---
    @@ -0,0 +1,88 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.examples
    +
    +import org.apache.commons.logging.LogFactory
    +import org.apache.hadoop.fs.{FileSystem, Path}
    +import org.apache.hadoop.mapred._
    +import org.apache.spark.{SparkConf, SparkContext}
    +import org.apache.spark.SparkContext._
    +
    +/**
    + * An OutputCommitter similar to the one used by default for s3:// URLs in EMR.
    + */
    +class DirectOutputCommitter extends OutputCommitter {
    --- End diff --
    
    It's great that you did this integration test to verify this is working. However, we usually
won't merge things like this into the repo because tests that aren't run regularly as part
of our harness don't provide much testing value (and often become out of date, etc).
    
    AFAIK the unit test provides pretty good coverage here. Would you mind dropping this from
the PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message