spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3584] sbin/slaves doesn't work when we ...
Date Fri, 19 Sep 2014 17:54:48 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2444#discussion_r17798769
  
    --- Diff: sbin/slaves.sh ---
    @@ -67,20 +69,26 @@ fi
     
     if [ "$HOSTLIST" = "" ]; then
       if [ "$SPARK_SLAVES" = "" ]; then
    -    export HOSTLIST="${SPARK_CONF_DIR}/slaves"
    +    if [ -f "${SPARK_CONF_DIR}/slaves" ]; then
    +      HOSTLIST=`cat "${SPARK_CONF_DIR}/slaves"`
    +    else
    +      HOSTLIST=localhost
    +    fi
       else
    -    export HOSTLIST="${SPARK_SLAVES}"
    +    HOSTLIST=`cat "${SPARK_SLAVES}"`
       fi
     fi
     
    +
    +
     # By default disable strict host key checking
     if [ "$SPARK_SSH_OPTS" = "" ]; then
       SPARK_SSH_OPTS="-o StrictHostKeyChecking=no"
     fi
     
    -for slave in `cat "$HOSTLIST"|sed  "s/#.*$//;/^$/d"`; do
    +for slave in `echo "$HOSTLIST"|sed  "s/#.*$//;/^$/d"`; do
      ssh $SPARK_SSH_OPTS "$slave" $"${@// /\\ }" \
    -   2>&1 | sed "s/^/$slave: /" &
    +   2>&1 | sed "s/^/$slave: /"
    --- End diff --
    
    I agree with matt - this will regress behavior for other users. Can we have a flag called
`SSH_FOREGROUND` that turns this on?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message