spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1767: Prefer HDFS-cached replicas when s...
Date Mon, 15 Sep 2014 03:48:36 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1486#discussion_r17525822
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskLocation.scala ---
    @@ -23,12 +23,33 @@ package org.apache.spark.scheduler
      * of preference will be executors on the same host if this is not possible.
      */
     private[spark]
    -class TaskLocation private (val host: String, val executorId: Option[String]) extends
Serializable {
    -  override def toString: String = "TaskLocation(" + host + ", " + executorId + ")"
    +sealed abstract class TaskLocation(val host: String) {
    +}
    +
    +case class ExecutorCacheTaskLocation(override val host: String, val executorId: String)
    --- End diff --
    
    could you make all of these `private[spark]` as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message