spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3294][SQL] Eliminates boxing costs from...
Date Sat, 13 Sep 2014 18:16:21 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2327#discussion_r17513542
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
    @@ -295,8 +295,16 @@ class HiveQuerySuite extends HiveComparisonTest {
         "SELECT (CASE WHEN key > 2 THEN 3 WHEN 2 > key THEN 2 ELSE 0 END) FROM src
WHERE key < 15")
     
       test("implement identity function using case statement") {
    -    val actual = sql("SELECT (CASE key WHEN key THEN key END) FROM src").collect().toSet
    -    val expected = sql("SELECT key FROM src").collect().toSet
    +    val actual = sql("SELECT (CASE key WHEN key THEN key END) FROM src")
    +      .map { case Row(i: Int) => i }
    +      .collect()
    +      .toSeq
    --- End diff --
    
    @liancheng - ping :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message