spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1656: Fix potential resource leaks
Date Fri, 12 Sep 2014 14:47:54 GMT
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/577#discussion_r17482426
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
    @@ -73,7 +73,17 @@ private[spark] class DiskStore(blockManager: BlockManager, diskManager:
DiskBloc
         val startTime = System.currentTimeMillis
         val file = diskManager.getFile(blockId)
         val outputStream = new FileOutputStream(file)
    -    blockManager.dataSerializeStream(blockId, outputStream, values)
    +    try {
    +      blockManager.dataSerializeStream(blockId, outputStream, values)
    +      outputStream.close()
    +    } catch {
    +      case e: Throwable => {
    +        outputStream.close()
    +        if(file.exists()) file.delete()
    +        throw e
    +      }
    +    }
    +
    --- End diff --
    
    I want to close the stream before deleting the file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message