spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davies <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3463] [PySpark] aggregate and show spil...
Date Fri, 12 Sep 2014 00:04:19 GMT
Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2336#discussion_r17457077
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
    @@ -242,7 +242,8 @@ class JobProgressListener(conf: SparkConf) extends SparkListener with
Logging {
                 t.taskMetrics)
     
               // Overwrite task metrics
    -          t.taskMetrics = Some(taskMetrics)
    +          // FIXME: deepcopy the metrics, or they will be the same object in local mode
    +          t.taskMetrics = Some(scala.util.Marshal.load[TaskMetrics](scala.util.Marshal.dump(taskMetrics)))
    --- End diff --
    
    I will rebase it after #2338 is merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message