spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3294][SQL] WIP: eliminates boxing costs...
Date Thu, 11 Sep 2014 18:24:30 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2327#discussion_r17438553
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnAccessor.scala ---
    @@ -51,10 +51,12 @@ private[sql] abstract class BasicColumnAccessor[T <: DataType,
JvmType](
       def hasNext = buffer.hasRemaining
     
       def extractTo(row: MutableRow, ordinal: Int) {
    --- End diff --
    
    This style is going to go away in 2.12 or 2.13 I think.  Should be `:Unit = `


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message