spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From benoyantony <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3286] - Cannot view ApplicationMaster U...
Date Tue, 09 Sep 2014 19:15:00 GMT
Github user benoyantony commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2276#discussion_r17321277
  
    --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
    @@ -189,7 +189,11 @@ private[spark] class ApplicationMaster(args: ApplicationMasterArguments,
         if (sc == null) {
           finish(FinalApplicationStatus.FAILED, "Timed out waiting for SparkContext.")
         } else {
    -      registerAM(sc.ui.appUIHostPort, securityMgr)
    +        var uiAddress = sc.ui.appUIHostPort
    +        if (yarnConf.get("yarn.http.policy").equals("HTTPS_ONLY")) {
    --- End diff --
    
    Thanks @tgravescs .
    So all stable versions are post YARN-1203 and can handle urls with scheme.
    Alpha versions cannot handle url with scheme.
    Address with scheme is passed from the ApplicationMaster.scala.
    There are only two cases.
    Stable :  pass the address with scheme. 
    Alpha : strips of the scheme from the address.
    
    I have changed the code appropriately


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message