spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mengxr <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3418] Sparse Matrix support (CCS) and a...
Date Mon, 08 Sep 2014 18:03:50 GMT
Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2294#discussion_r17255300
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala ---
    @@ -36,9 +36,34 @@ trait Matrix extends Serializable {
       /** Converts to a breeze matrix. */
       private[mllib] def toBreeze: BM[Double]
     
    -  /** Gets the (i, j)-th element. */
    -  private[mllib] def apply(i: Int, j: Int): Double = toBreeze(i, j)
    +  /** Gets the i-th element in the array backing the matrix. */
    +  private[mllib] def apply(i: Int): Double
     
    +  /** Gets the (r, c)-th element. */
    +  private[mllib] def apply(r: Int, c: Int): Double
    --- End diff --
    
    `i, j` is more common


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message