spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From SparkQA <...@git.apache.org>
Subject [GitHub] spark pull request: [HOTFIX] Fix broken Mima tests on the master b...
Date Mon, 08 Sep 2014 01:39:59 GMT
Github user SparkQA commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2315#discussion_r17219377
  
    --- Diff: project/MimaExcludes.scala ---
    @@ -33,6 +33,18 @@ import com.typesafe.tools.mima.core._
     object MimaExcludes {
         def excludes(version: String) =
           version match {
    +        case v if v.startsWith("1.2") =>
    +          Seq(
    +            MimaBuild.excludeSparkPackage("deploy"),
    --- End diff --
    
    can you just pull this into an exclude that is always run rather than version-specific?
This is simply not part of the Spark API and is separately excluded from other stuff too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message