spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgravescs <...@git.apache.org>
Subject [GitHub] spark pull request: Don't include the empty string "" as a default...
Date Fri, 05 Sep 2014 14:15:12 GMT
Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2286#discussion_r17174246
  
    --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
    @@ -162,7 +162,7 @@ private[spark] class SecurityManager(sparkConf: SparkConf) extends
Logging {
     
       // always add the current user and SPARK_USER to the viewAcls
       private val defaultAclUsers = Set[String](System.getProperty("user.name", ""),
    -    Option(System.getenv("SPARK_USER")).getOrElse(""))
    +    Option(System.getenv("SPARK_USER")).getOrElse("")).filter(_ != "")
    --- End diff --
    
    can you change this to be !_.isEmpty


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message