spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-2978. Transformation with MR shuffle sem...
Date Thu, 04 Sep 2014 20:41:35 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2274#discussion_r17140599
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/OrderedRDDFunctions.scala ---
    @@ -64,4 +64,15 @@ class OrderedRDDFunctions[K : Ordering : ClassTag,
         new ShuffledRDD[K, V, V](self, part)
           .setKeyOrdering(if (ascending) ordering else ordering.reverse)
       }
    +
    +  /**
    +   * Repartition the RDD according to the given partitioner and, within each resulting
partition,
    +   * sort records by their keys.
    --- End diff --
    
    can u add some documentation explaining this is functionally similar to doing repartition
and then sort within each function, except it is more optimized because we can push the sorting
into the shuffle process?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message