spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adrian-wang <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3363][SQL] Type Coercion should support...
Date Thu, 04 Sep 2014 05:47:36 GMT
Github user adrian-wang commented on the pull request:

    https://github.com/apache/spark/pull/2246#issuecomment-54410117
  
    I made a mistake here, This part cannot use `findTightestCommonType(t1, t2)`, because
we should not return the value only if the 2 types are the same. That is, for two Struct(field)
type, we need to compare the field name to decide.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message