spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shivaram <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3019] Pluggable block transfer interfac...
Date Wed, 03 Sep 2014 03:44:17 GMT
Github user shivaram commented on the pull request:

    https://github.com/apache/spark/pull/2240#issuecomment-54248714
  
    I took a very brief look -- Will take a closer look when I find some more time. But here
are a couple of high-level comments
    
    1. It would be better IMHO to split this into 2 PRs, one just for renaming / moving classes
and the other for adding new stuff. That would make reviewing much easier (for example I don't
know if any code changed in ShuffleBlockFetchIterator right now)
    
    2. I am not a big fan of the package name `cm`. I know `connectionmanager` is a mouthful,
but my suggestion would actually be to keep everything in `network` till we figure out how
to split things into sub-packages. I think ideally we'd like common traits / abstract classes
to be in network/ and then have `netty` and `nio` etc. as sub-packages (the connection manager
uses nio right ?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message