spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shivaram <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3019] Pluggable block transfer interfac...
Date Wed, 03 Sep 2014 03:25:38 GMT
Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2240#discussion_r17029823
  
    --- Diff: core/src/main/scala/org/apache/spark/network/BlockTransferService.scala ---
    @@ -0,0 +1,114 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.network
    +
    +import org.apache.spark.storage.StorageLevel
    +
    +
    +abstract class BlockTransferService {
    +
    +  /**
    +   * Initialize the transfer service by giving it the BlockDataManager that can be used
to fetch
    +   * local blocks or put local blocks.
    +   */
    +  def init(blockDataManager: BlockDataManager)
    +
    +  /**
    +   * Tear down the transfer service.
    +   */
    +  def stop(): Unit
    +
    +  /**
    +   * Port number the service is listening on, available only after [[init]] is invoked.
    +   */
    +  def port: Int
    +
    +  /**
    +   * Host name the service is listening on, available only after [[init]] is invoked.
    +   */
    +  def hostName: String
    +
    +  /**
    +   * Fetch a sequence of blocks from a remote node asynchronously,
    +   * available only after [[init]] is invoked.
    +   *
    +   * Note that [[BlockFetchingListener.onBlockFetchSuccess]] is called once per block,
    +   * while [[BlockFetchingListener.onBlockFetchSuccess]] is called once per failure.
    +   *
    +   * This takes a sequence so the implementation can batch requests.
    +   */
    +  def fetchBlocks(
    +      hostName: String,
    +      port: Int,
    +      blockIds: Seq[String],
    +      listener: BlockFetchingListener): Unit
    +
    +  /**
    +   * Fetch a single block from a remote node, synchronously,
    +   * available only after [[init]] is invoked.
    +   */
    +  def fetchBlock(hostName: String, port: Int, blockId: String): ManagedBuffer = {
    --- End diff --
    
    Is this implemented here just for ease of testing ? I mean why do we need this single
block fetch + blocking listener as a special case ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message