spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenghao-intel <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2219][SQL] Added support for the "add j...
Date Wed, 03 Sep 2014 01:39:40 GMT
Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2242#discussion_r17027653
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/commands.scala ---
    @@ -72,3 +72,24 @@ case class DropTable(tableName: String, ifExists: Boolean) extends
LeafNode with
         sparkContext.emptyRDD[Row]
       }
     }
    +
    +/**
    + * :: DeveloperApi ::
    + */
    +@DeveloperApi
    +case class AddJar(path: String) extends LeafNode with Command {
    --- End diff --
    
    I saw `SetCommand` takes the `context` as the parameter, as well as the other `Command`s
in the file `commands.scala`, like:
    ```
    case class SetCommand(
        key: Option[String], value: Option[String], output: Seq[Attribute])(
        @transient context: SQLContext)
    ```
    Should we follow the same pattern? The default `sqlContext` will take value from a ThreadLocal
variable, which probably a little different.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message