spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sryza <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1767: Prefer HDFS-cached replicas when s...
Date Tue, 02 Sep 2014 22:22:22 GMT
Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1486#discussion_r17020310
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/PartitionLocation.scala ---
    @@ -0,0 +1,49 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.rdd
    +
    +private[spark] object PartitionPriority extends Enumeration {
    +  val NORMAL, IN_MEMORY = Value
    +}
    +
    +/**
    + * The location of an RDD partition.
    + */
    +private[spark] class PartitionLocation(val host : String,
    +    val priority : PartitionPriority.Value) {
    +  override def toString() : String = {
    +    priority match {
    +      case PartitionPriority.NORMAL => host
    +      case PartitionPriority.IN_MEMORY =>
    +        PartitionLocation.IN_MEMORY_LOCATION_TAG + host
    +    }
    +  }
    +}
    +
    +private[spark] object PartitionLocation {
    +  val IN_MEMORY_LOCATION_TAG = "_M_"
    +
    +  def fromString(str : String) : PartitionLocation = {
    +    if (str.indexOf(IN_MEMORY_LOCATION_TAG) >= 0) {
    +      new PartitionLocation(str.replaceAll(IN_MEMORY_LOCATION_TAG, ""),
    --- End diff --
    
    replaceAll uses regexes, which can be expensive.  Instead of indexOf and and replaceAll,
can we use startsWith in the condition and substring?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message