Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5A3E3118BE for ; Fri, 15 Aug 2014 00:27:47 +0000 (UTC) Received: (qmail 92828 invoked by uid 500); 15 Aug 2014 00:27:47 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 92803 invoked by uid 500); 15 Aug 2014 00:27:47 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 92780 invoked by uid 99); 15 Aug 2014 00:27:46 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Aug 2014 00:27:46 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id AD8E89C41F0; Fri, 15 Aug 2014 00:27:46 +0000 (UTC) From: harishreedharan To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org Message-ID: Subject: [GitHub] spark pull request: [SPARK-3054][STREAMING] Add unit tests for Spa... Content-Type: text/plain Date: Fri, 15 Aug 2014 00:27:46 +0000 (UTC) GitHub user harishreedharan opened a pull request: https://github.com/apache/spark/pull/1958 [SPARK-3054][STREAMING] Add unit tests for Spark Sink. This patch adds unit tests for Spark Sink. It also removes the private[flume] for Spark Sink, since the sink is instantiated from Flume configuration (looks like this is ignored by reflection which is used by Flume, but we should still remove it anyway). You can merge this pull request into a Git repository by running: $ git pull https://github.com/harishreedharan/spark spark-sink-test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/1958.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1958 ---- commit c86d615fbc90f46aea6359a66d10195be69de62a Author: Hari Shreedharan Date: 2014-08-15T00:19:51Z [SPARK-3054][STREAMING] Add unit tests for Spark Sink. This patch adds unit tests for Spark Sink. It also removes the private[flume] for Spark Sink, since the sink is instantiated from Flume configuration (looks like this is ignored by reflection which is used by Flume, but we should still remove it anyway). commit a24aac80236e729b2117b2c11eff2d1f456eae4d Author: Hari Shreedharan Date: 2014-08-15T00:26:44Z Remove unused var ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org