Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5C4731183B for ; Thu, 28 Aug 2014 23:22:45 +0000 (UTC) Received: (qmail 11272 invoked by uid 500); 28 Aug 2014 23:22:45 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 11265 invoked by uid 500); 28 Aug 2014 23:22:45 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 11254 invoked by uid 99); 28 Aug 2014 23:22:44 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Aug 2014 23:22:44 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id B281A82CF6F; Thu, 28 Aug 2014 23:22:44 +0000 (UTC) From: srowen To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [SPARK-3061] Fix Maven build under Windows Content-Type: text/plain Message-Id: <20140828232244.B281A82CF6F@tyr.zones.apache.org> Date: Thu, 28 Aug 2014 23:22:44 +0000 (UTC) Github user srowen commented on the pull request: https://github.com/apache/spark/pull/2165#issuecomment-53819995 Re: can this break something -- we have seen in recent memory how zip behavior can be inconsistent with archives of >= 65536 files, which comes up with Spark assembly jars. I assume that's not true of the .zip file being unzipped here though. In that case this does seem like something that will work everywhere if it works anywhere. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org