Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 69CC5117AB for ; Wed, 27 Aug 2014 12:53:14 +0000 (UTC) Received: (qmail 82757 invoked by uid 500); 27 Aug 2014 12:53:14 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 82735 invoked by uid 500); 27 Aug 2014 12:53:14 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 82721 invoked by uid 99); 27 Aug 2014 12:53:14 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Aug 2014 12:53:14 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id B790B9CB149; Wed, 27 Aug 2014 12:53:13 +0000 (UTC) From: yu-iskw To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [SPARK-3012] Standardized Distance Functions b... Content-Type: text/plain Message-Id: <20140827125313.B790B9CB149@tyr.zones.apache.org> Date: Wed, 27 Aug 2014 12:53:13 +0000 (UTC) Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/1964#issuecomment-53567544 @mengxr Thank you for your comment. I expect users are able to pick different distance measure in clustering algorithm, such as k-means. And I agree with you in your view. We should hide the distance function implementation from users. But users should easily specify the distance type in clustering algorithm arguments. Would you please point out any mistakes to me in my code. If there is any problems in terms of the interface of distance function, I would like to merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org