Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 35CC711DD2 for ; Tue, 26 Aug 2014 02:31:10 +0000 (UTC) Received: (qmail 82626 invoked by uid 500); 26 Aug 2014 02:31:10 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 82618 invoked by uid 500); 26 Aug 2014 02:31:10 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 82607 invoked by uid 99); 26 Aug 2014 02:31:09 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Aug 2014 02:31:09 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 7C3969CE776; Tue, 26 Aug 2014 02:31:09 +0000 (UTC) From: mateiz To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [SPARK-2889] Create Hadoop config objects cons... Content-Type: text/plain Message-Id: <20140826023109.7C3969CE776@tyr.zones.apache.org> Date: Tue, 26 Aug 2014 02:31:09 +0000 (UTC) Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/1843#discussion_r16693018 --- Diff: examples/src/main/scala/org/apache/spark/examples/SparkTachyonHdfsLR.scala --- @@ -52,8 +52,8 @@ object SparkTachyonHdfsLR { def main(args: Array[String]) { val inputPath = args(0) - val conf = SparkHadoopUtil.get.newConfiguration() val sparkConf = new SparkConf().setAppName("SparkTachyonHdfsLR") + val conf = SparkHadoopUtil.get.newConfiguration(sparkConf) --- End diff -- Same here, let's not use this in examples --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org