Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: mengxr <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-1950-spark@git.apache.org>
In-Reply-To: <git-pr-1950-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-3022] [SPARK-3041] [mllib] Call
 findBin...
Content-Type: text/plain
Message-Id: <20140815042320.96B139C47A2@tyr.zones.apache.org>
Date: Fri, 15 Aug 2014 04:23:20 +0000 (UTC)

Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1950#discussion_r16279806
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
    @@ -550,25 +579,35 @@ object DecisionTree extends Serializable with Logging {
     
           // Apply each filter and check sample validity. Return false when invalid condition found.
           for (filter <- parentFilters) {
    --- End diff --
    
    Please update this line to `parentFilter.foreach { filter =>` which is faster than `for`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org