spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From watermen <...@git.apache.org>
Subject [GitHub] spark pull request: Using values.sum is easier to understand than ...
Date Thu, 28 Aug 2014 11:33:41 GMT
GitHub user watermen opened a pull request:

    https://github.com/apache/spark/pull/2182

    Using values.sum is easier to understand than using values.foldLeft(0)(_ + _)

    def sum[B >: A](implicit num: Numeric[B]): B = foldLeft(num.zero)(num.plus)
    Using values.sum is easier to understand than using values.foldLeft(0)(_ + _), so we'd
better use values.sum instead of values.foldLeft(0)(_ + _)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/watermen/spark bug-fix3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/2182.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2182
    
----
commit 57e704c5ee0423fbdc9302895d4decad1b4164ef
Author: Yadong Qi <qiyadong2010@gmail.com>
Date:   2014-08-28T11:16:38Z

    Update StatefulNetworkWordCount.scala

commit 714bda5983dd08f5a5a5a850b09ad50955c65a33
Author: Yadong Qi <qiyadong2010@gmail.com>
Date:   2014-08-28T11:17:28Z

    Update BasicOperationsSuite.scala

commit 17be9fb734d442c86723080e3df03007e002c364
Author: Yadong Qi <qiyadong2010@gmail.com>
Date:   2014-08-28T11:23:41Z

    Update CheckpointSuite.scala

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message