spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From harishreedharan <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3054][STREAMING] Add unit tests for Spa...
Date Fri, 15 Aug 2014 00:27:46 GMT
GitHub user harishreedharan opened a pull request:

    https://github.com/apache/spark/pull/1958

    [SPARK-3054][STREAMING] Add unit tests for Spark Sink.

    This patch adds unit tests for Spark Sink.
    
    It also removes the private[flume] for Spark Sink,
    since the sink is instantiated from Flume configuration (looks like this is ignored by
reflection which is used by
    Flume, but we should still remove it anyway).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/harishreedharan/spark spark-sink-test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/1958.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1958
    
----
commit c86d615fbc90f46aea6359a66d10195be69de62a
Author: Hari Shreedharan <hshreedharan@apache.org>
Date:   2014-08-15T00:19:51Z

    [SPARK-3054][STREAMING] Add unit tests for Spark Sink.
    
    This patch adds unit tests for Spark Sink.
    
    It also removes the private[flume] for Spark Sink,
    since the sink is instantiated from Flume configuration (looks like this is ignored by
reflection which is used by
    Flume, but we should still remove it anyway).

commit a24aac80236e729b2117b2c11eff2d1f456eae4d
Author: Hari Shreedharan <hshreedharan@apache.org>
Date:   2014-08-15T00:26:44Z

    Remove unused var

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message