spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manishamde <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3086] [SPARK-3043] [SPARK-3156] [mllib]...
Date Thu, 28 Aug 2014 22:09:45 GMT
Github user manishamde commented on the pull request:

    https://github.com/apache/spark/pull/2125#issuecomment-53810214
  
    I have made one pass and it's a fantastic PR. Apart from the performance benefits, the
code improvements are awesome.
    
    I still need to make another pass and look closely at some methods especially ```binsToBestSplit```.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message