spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <>
Subject [GitHub] spark pull request: [SPARK-2288] Hide ShuffleBlockManager behind S...
Date Wed, 27 Aug 2014 08:11:23 GMT
Github user rxin commented on a diff in the pull request:
    --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
    @@ -121,20 +129,16 @@ private[spark] class DiskStore(blockManager: BlockManager, diskManager:
       override def remove(blockId: BlockId): Boolean = {
    -    val fileSegment = diskManager.getBlockLocation(blockId)
    -    val file = fileSegment.file
    -    if (file.exists() && file.length() == fileSegment.length) {
    +    val file = diskManager.getFile(
    --- End diff --
    are you saying diskManager.getFile would return a file that doens't exist when consolidation
is on? if that's the case, can u add inline comment explaining this

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message