spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <>
Subject [GitHub] spark pull request: [SPARK-3167] Handle special driver configs in ...
Date Wed, 27 Aug 2014 01:29:27 GMT
Github user andrewor14 commented on a diff in the pull request:
    --- Diff: bin/spark-class2.cmd ---
    @@ -115,5 +125,27 @@ rem Figure out where java is.
     set RUNNER=java
     if not "x%JAVA_HOME%"=="x" set RUNNER=%JAVA_HOME%\bin\java
    -"%RUNNER%" -cp "%CLASSPATH%" %JAVA_OPTS% %*
    +rem In Spark submit client mode, the driver is launched in the same JVM as Spark submit
    +rem Here we must parse the properties file for relevant "spark.driver.*" configs before
    +rem the driver JVM itself. Instead of handling this complexity in Bash, we launch a separate
    +rem to prepare the launch environment of this driver JVM.
    +rem In this case, leave out the main class (org.apache.spark.deploy.SparkSubmit) and
use our own.
    +rem Leaving out the first argument is surprisingly difficult to do in Windows. Note that
this must
    +rem be done here because the Windows "shift" command does not work in a conditional block.
    +if "%~1" == "" goto end_parse
    +goto start_parse
    +if not [%SPARK_SUBMIT_BOOTSTRAP_DRIVER%] == [] (
    +  set SPARK_CLASS=1
    +  "%RUNNER%" org.apache.spark.deploy.SparkSubmitDriverBootstrapper %BOOTSTRAP_ARGS%
    --- End diff --
    JK, this was actually fixed in

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message