spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [WIP][SPARK-3167] Handle special driver config...
Date Wed, 27 Aug 2014 00:33:27 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2129#discussion_r16752033
  
    --- Diff: bin/spark-class2.cmd ---
    @@ -115,5 +125,27 @@ rem Figure out where java is.
     set RUNNER=java
     if not "x%JAVA_HOME%"=="x" set RUNNER=%JAVA_HOME%\bin\java
     
    -"%RUNNER%" -cp "%CLASSPATH%" %JAVA_OPTS% %*
    +rem In Spark submit client mode, the driver is launched in the same JVM as Spark submit
itself.
    +rem Here we must parse the properties file for relevant "spark.driver.*" configs before
launching
    +rem the driver JVM itself. Instead of handling this complexity in Bash, we launch a separate
JVM
    +rem to prepare the launch environment of this driver JVM.
    +
    +rem In this case, leave out the main class (org.apache.spark.deploy.SparkSubmit) and
use our own.
    +rem Leaving out the first argument is surprisingly difficult to do in Windows. Note that
this must
    +rem be done here because the Windows "shift" command does not work in a conditional block.
    +set BOOTSTRAP_ARGS=
    +shift
    +:start_parse
    +if "%~1" == "" goto end_parse
    +set BOOTSTRAP_ARGS=%BOOTSTRAP_ARGS% %~1
    +shift
    +goto start_parse
    +:end_parse
    +
    +if not [%SPARK_SUBMIT_BOOTSTRAP_DRIVER%] == [] (
    +  set SPARK_CLASS=1
    +  "%RUNNER%" org.apache.spark.deploy.SparkSubmitDriverBootstrapper %BOOTSTRAP_ARGS%
    --- End diff --
    
    This should be fixed in this commit https://github.com/andrewor14/spark/commit/f97daa20c184fb4b68d7ff5de1172a8e94e38b2f


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message