spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2849] Handle driver configs separately ...
Date Tue, 19 Aug 2014 17:16:53 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1845#discussion_r16428889
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitDriverBootstrapper.scala
---
    @@ -0,0 +1,122 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.deploy
    +
    +import java.io.File
    +
    +import scala.collection.JavaConversions._
    +
    +import org.apache.spark.util.{RedirectThread, Utils}
    +
    +/**
    + * Launch an application through Spark submit in client mode with the appropriate classpath,
    + * library paths, java options and memory. These properties of the JVM must be set before
the
    + * driver JVM is launched. The sole purpose of this class is to avoid handling the complexity
    + * of parsing the properties file for such relevant configs in BASH.
    + *
    + * Usage: org.apache.spark.deploy.SparkSubmitDriverBootstrapper <application args>
    + */
    +private[spark] object SparkSubmitDriverBootstrapper {
    +
    +  // Note: This class depends on the behavior of `bin/spark-class` and `bin/spark-submit`.
    +  // Any changes made there must be reflected in this file.
    +
    +  def main(args: Array[String]): Unit = {
    +    val submitArgs = args
    +    val runner = sys.env("RUNNER")
    +    val classpath = sys.env("CLASSPATH")
    +    val javaOpts = sys.env("JAVA_OPTS")
    +    val defaultDriverMemory = sys.env("OUR_JAVA_MEM")
    +
    +    // Spark submit specific environment variables
    +    val deployMode = sys.env("SPARK_SUBMIT_DEPLOY_MODE")
    +    val propertiesFile = sys.env("SPARK_SUBMIT_PROPERTIES_FILE")
    +    val bootstrapDriver = sys.env("SPARK_SUBMIT_BOOTSTRAP_DRIVER")
    +    val submitDriverMemory = sys.env.get("SPARK_SUBMIT_DRIVER_MEMORY")
    +    val submitLibraryPath = sys.env.get("SPARK_SUBMIT_LIBRARY_PATH")
    +    val submitClasspath = sys.env.get("SPARK_SUBMIT_CLASSPATH")
    +    val submitJavaOpts = sys.env.get("SPARK_SUBMIT_JAVA_OPTS")
    +
    +    assume(runner != null, "RUNNER must be set")
    +    assume(classpath != null, "CLASSPATH must be set")
    +    assume(javaOpts != null, "JAVA_OPTS must be set")
    +    assume(defaultDriverMemory != null, "OUR_JAVA_MEM must be set")
    +    assume(deployMode == "client", "SPARK_SUBMIT_DEPLOY_MODE must be \"client\"!")
    +    assume(propertiesFile != null, "SPARK_SUBMIT_PROPERTIES_FILE must be set")
    +    assume(bootstrapDriver != null, "SPARK_SUBMIT_BOOTSTRAP_DRIVER must be set!")
    +
    +    // Parse the properties file for the equivalent spark.driver.* configs
    +    val properties = SparkSubmitArguments.getPropertiesFromFile(new File(propertiesFile)).toMap
    +    val confDriverMemory = properties.get("spark.driver.memory").getOrElse(defaultDriverMemory)
    +    val confLibraryPath = properties.get("spark.driver.extraLibraryPath").getOrElse("")
    +    val confClasspath = properties.get("spark.driver.extraClassPath").getOrElse("")
    +    val confJavaOpts = properties.get("spark.driver.extraJavaOptions").getOrElse("")
    +
    +    // Favor Spark submit arguments over the equivalent configs in the properties file.
    +    // Note that we do not actually use the Spark submit values for library path, classpath,
    +    // and java opts here, because we have already captured them in BASH.
    --- End diff --
    
    Java opts and Bash


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message