spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From harishreedharan <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3054][STREAMING] Add unit tests for Spa...
Date Mon, 18 Aug 2014 21:54:21 GMT
Github user harishreedharan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1958#discussion_r16384773
  
    --- Diff: external/flume-sink/src/main/scala/org/apache/spark/streaming/flume/sink/SparkSink.scala
---
    @@ -53,7 +53,6 @@ import org.apache.flume.sink.AbstractSink
      *
      */
     
    -private[flume]
    --- End diff --
    
    Since this class would be called from Flume. Flume will create an instance of this class
to run the sink - so theoretically it should not be private to this package.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message