spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mengxr <>
Subject [GitHub] spark pull request: [SPARK-3022] [SPARK-3041] [mllib] Call findBin...
Date Fri, 15 Aug 2014 04:23:20 GMT
Github user mengxr commented on a diff in the pull request:
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
    @@ -550,25 +579,35 @@ object DecisionTree extends Serializable with Logging {
           // Apply each filter and check sample validity. Return false when invalid condition
           for (filter <- parentFilters) {
    --- End diff --
    Please update this line to `parentFilter.foreach { filter =>` which is faster than

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message