spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mateiz <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2759][CORE] Generic Binary File Support...
Date Wed, 13 Aug 2014 21:28:12 GMT
Github user mateiz commented on the pull request:

    https://github.com/apache/spark/pull/1658#issuecomment-52113865
  
    BTW apart from that, a few other comments:
    - Make sure that the classes / objects you add are `private[spark]` so they don't show
up in the API docs and such.
    - You should also design some test suites for this to put in core/src/test. Take a look
at other test suites to see how ScalaTest works and how we create temp files. Basically you
want to create some files programmatically in the test, then try to read them with this API.
    
    Thanks for the continued work on this BTW, it's looking great.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message