spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2894] spark-shell doesn't accept flags
Date Sat, 09 Aug 2014 18:21:38 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1825#discussion_r16027150
  
    --- Diff: python/pyspark/java_gateway.py ---
    @@ -39,7 +39,11 @@ def launch_gateway():
             submit_args = os.environ.get("PYSPARK_SUBMIT_ARGS")
             submit_args = submit_args if submit_args is not None else ""
             submit_args = shlex.split(submit_args)
    -        command = [os.path.join(SPARK_HOME, script), "pyspark-shell"] + submit_args
    +        application_opts = os.environ.get("APPLICATION_OPTS")
    +        application_opts = application_opts if application_opts is not None else ""
    +        application_opts = shlex.split(application_opts)
    +        command = [os.path.join(SPARK_HOME, script)] + submit_args + \
    +            ["pyspark-shell"] + application_opts
    --- End diff --
    
    We actually do need the application arguments here. Note that this code path is only for
the pyspark shell, and in `bin/pyspark` we only handle the application arguments for the python
file case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message